Track sign up details #24722
Track sign up details #24722
Conversation
…you_do_not_do_anything in SessionCookieTest)
| unless session[:sign_up_tracking_expiration]&.future? | ||
| session[:sign_up_uid] = SecureRandom.uuid.to_s | ||
| session[:sign_up_tracking_expiration] = 5.minutes.from_now | ||
| FirehoseClient.instance.put_record( |
There was a problem hiding this comment.
Tracking question: We're only putting the 'load-sign-up-page' event if we didn't already start tracking. Are we intentionally squelching the case where a user hits the signup page then reloads it within the 5-minute window? I'm wondering if this put_record should be outside the if-statement, or in a separate if-statement.
| # our tracking data is usually populated, so do it here | ||
| unless session[:sign_up_tracking_expiration]&.future? | ||
| session[:sign_up_uid] = SecureRandom.uuid.to_s | ||
| session[:sign_up_tracking_expiration] = 5.minutes.from_now |
There was a problem hiding this comment.
This two- or three-step session setup happens a couple of times in this PR - might be a good candidate for extraction to something like SignUpTracking.begin_sign_up_tracking(session).
| data_string: session[:sign_up_uid], | ||
| data_json: { | ||
| detail: resource.to_json, | ||
| errors: resource.errors&.messages |
There was a problem hiding this comment.
should this be full_messages instead of mesages? not sure that it matters, just changes the formatting of the error messages
…rror, send load-sign-up-page on each reload
Logs the following events into Firehose/Redshift:
load-sign-up-page (when user loads sign up page)
select-teacher (when user selects teacher user type)
select-student (when user selects student user type)
email-sign-up-success (when user successfully signs up with email / password account)
google-sign-up-success (when user successfully signs up through Google account)
microsoft-sign-up-success (when user successfully signs up through Microsoft account)
facebook-sign-up-success (when user successfully signs up through Facebook account)
clever-sign-up-success (when user successfully signs up through Clever account)
powerschool-sign-up-success (when user successfully signs up through PowerSchool account)
other-sign-up-success (when user successfully signs up through some other means we’re not tracking, e.g. some other third party provider used internationally)
email-sign-up-error (when user hits an error after trying to sign up through email / password account)
google-sign-up-error (when user hits an error after trying to sign up through Google account)
microsoft-sign-up-error (when user hits an error after trying to sign up through Microsoft account)
facebook-sign-up-error (when user hits an error after trying to sign up through Facebook account)
clever-sign-up-error (when user hits an error after trying to sign up through Clever account)
powerschool-sign-up-error (when user hits an error after trying to sign up through PowerSchool account)
other-sign-up-error (when user hits an error after trying to sign up through some other means we’re not tracking)
google-sign-in (when user signs in through Google from the sign up page)
microsoft-sign-in (when user signs in through Microsoft from the sign up page)
facebook-sign-in (when user signs in through Facebook from the sign up page)