Set unit when sending NetSim metrics #24757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets the appropriate unit when sending NetSim metrics to Cloudwatch. In this particular case, our unit is always either "Count" or "Bytes". See [the docs](https://docs.aws.amazon.com/sdkforruby/api/Aws/CloudWatch/Types/MetricDatum.html#unit-instance_method) for possible values to the `:unit` parameter.
clareconstantine
approved these changes
Sep 12, 2018
shared/middleware/net_sim_api.rb
Outdated
| @@ -504,7 +504,7 @@ def delete_messages_for_nodes(shard_id, node_ids) | |||
| # @param [String] event_type - unique metric key within NetSimApi | |||
| # @param [Number] value (default 1) value of measurement, omit if we only care | |||
| # about event counts. | |||
| def record_metric(event_type, value = 1) | |||
| def record_metric(event_type, value = 1, unit = 'Count') | |||
There was a problem hiding this comment.
super small - I would add a param comment for the new param, just because we have them for the others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the appropriate unit when sending NetSim metrics to Cloudwatch. In this particular case, our unit is always either "Count" or "Bytes". See the docs for possible values to the
:unitparameter.