Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primary_contact_info_id to list of restricted attributes #24770

Merged
merged 3 commits into from Sep 13, 2018
Merged

Add primary_contact_info_id to list of restricted attributes #24770

merged 3 commits into from Sep 13, 2018

Conversation

maddiedierker
Copy link
Contributor

Fixes this Honeybadger error. For reference, a similar problem came up and was fixed in #24659

@maddiedierker
Copy link
Contributor Author

add primary_contact_info_id to list of restricted attributes

aoby
aoby approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@aoby aoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

Note we currently don't have a single test for this get :facilitator_courses_form route. Even a basic test that called the action and verified response :success would have caught this bug.

@maddiedierker
Copy link
Contributor Author

maddiedierker commented Sep 13, 2018 •
edited

@aoby these tests currently test the rendering functionality for get :facilitator_courses_form, but there wasn't a test for where the user being searched was a multi-auth user, so i added one. thanks!

@maddiedierker maddiedierker merged commit 0322f8e into staging Sep 13, 2018
@maddiedierker maddiedierker deleted the add-primary-contact-info-attribute branch September 13, 2018 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoby aoby aoby approved these changes

@sureshc sureshc Awaiting requested review from sureshc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maddiedierker @aoby