Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Release Records Procedure #24808

Merged
merged 5 commits into from Sep 17, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/i18n/common/en_us.json
Expand Up @@ -377,7 +377,7 @@
"deleteAccountDialog_checkboxPreface": "I understand that by deleting my account, ",
"deleteAccountDialog_checkboxTitle": "Please verify the following {numCheckboxes, plural, one {statement} other {statements}} before you can delete your account:",
"deleteAccountDialog_checkbox1_1": "I have the authority to delete the education records ",
"deleteAccountDialog_checkbox1_2": "of the students in my sections (or release it to them, if they have a personal login).",
"deleteAccountDialog_checkbox1_2": "of the students in my sections (or release it to them, if they have a personal login). ",
"deleteAccountDialog_checkbox2_1": "I am aware of the ",
"deleteAccountDialog_checkbox2_2": "message to send to parents ",
"deleteAccountDialog_checkbox2_3": "to warn them that their children’s coding projects will be deleted unless they act to preserve it by creating a personal login for their children.",
Expand Down Expand Up @@ -1044,8 +1044,8 @@
"removeFromClassGallery": "Remove from Class Gallery",
"removeFromPublicGallery": "Remove from Public Gallery",
"removeStudent": "Remove student",
"removeStudentAndRecordsHeader": "Remove {studentName} and release their education records?",
"removeStudentBody1": "Make sure you have authority from the school to release this student’s education records",
"removeStudentAndRecordsHeader": "Remove {studentName} and release the education records to the student?",
"removeStudentBody1": "Make sure you have authority from the school to release this student’s education records to them",
"removeStudentBody2": "before removing them from your section. If the student is not in a teacher’s section, they will be in full control of their data and have the ability to delete their account, including their course progress and projects.",
"removeStudentBody3": "This student will no longer be able to sign in to their account once you remove them. Please give your student a chance to keep using their Code.org account by allowing them to create a personal login.",
"removeStudentBody4": "Give them at least a few days to follow these instructions before you remove them.",
Expand Down
5 changes: 4 additions & 1 deletion apps/src/lib/ui/accounts/DeleteAccountHelpers.jsx
@@ -1,7 +1,7 @@
import React from 'react';
import _ from 'lodash';
import i18n from '@cdo/locale';
import {ADD_A_PERSONAL_LOGIN_HELP_URL} from '@cdo/apps/lib/util/urlHelpers';
import {ADD_A_PERSONAL_LOGIN_HELP_URL, RELEASE_OR_DELETE_RECORDS_EXPLANATION} from '@cdo/apps/lib/util/urlHelpers';

export const TeacherWarning = () => {
return (
Expand Down Expand Up @@ -54,6 +54,9 @@ const CHECKBOX_MAP = {
<span>
<strong>{i18n.deleteAccountDialog_checkbox1_1()}</strong>
{i18n.deleteAccountDialog_checkbox1_2()}
<a href={RELEASE_OR_DELETE_RECORDS_EXPLANATION} target="_blank">
{i18n.learnMore()}
</a>
</span>
)
},
Expand Down
1 change: 1 addition & 0 deletions apps/src/lib/util/urlHelpers.js
Expand Up @@ -37,3 +37,4 @@ export const metaTagDescription = _.memoize((relativeUrl) => {
});

export const ADD_A_PERSONAL_LOGIN_HELP_URL = 'https://support.code.org/hc/en-us/articles/115001475131-Adding-a-personal-login-to-a-teacher-created-account';
export const RELEASE_OR_DELETE_RECORDS_EXPLANATION = 'https://support.code.org/hc/en-us/articles/360015983631';
Expand Up @@ -5,7 +5,7 @@ import {Header, ConfirmCancelFooter} from '../../lib/ui/SystemDialog/SystemDialo
import BaseDialog from '../BaseDialog';
import Button from "../Button";
import color from "../../util/color";
import {ADD_A_PERSONAL_LOGIN_HELP_URL} from '../../lib/util/urlHelpers';
import {ADD_A_PERSONAL_LOGIN_HELP_URL, RELEASE_OR_DELETE_RECORDS_EXPLANATION} from "@cdo/apps/lib/util/urlHelpers";

// A stub set of otherwise-required props for use in stories and unit tests.
export const MINIMUM_TEST_PROPS = {
Expand Down Expand Up @@ -57,6 +57,10 @@ export default class ConfirmRemoveStudentDialog extends React.Component {
<strong>{i18n.removeStudentBody1()}</strong>
{' '}
{i18n.removeStudentBody2()}
{' '}
<a href={RELEASE_OR_DELETE_RECORDS_EXPLANATION} target="_blank">
{i18n.learnMore()}
</a>
</p>
{dependsOnThisSectionForLogin &&
<div>
Expand Down
Expand Up @@ -5,7 +5,7 @@ import {expect} from '../../../util/configuredChai';
import ConfirmRemoveStudentDialog, {MINIMUM_TEST_PROPS} from '@cdo/apps/templates/manageStudents/ConfirmRemoveStudentDialog';
import Button from '@cdo/apps/templates/Button';
import {Header, ConfirmCancelFooter} from '@cdo/apps/lib/ui/SystemDialog/SystemDialog';
import {ADD_A_PERSONAL_LOGIN_HELP_URL} from '@cdo/apps/lib/util/urlHelpers';
import {ADD_A_PERSONAL_LOGIN_HELP_URL, RELEASE_OR_DELETE_RECORDS_EXPLANATION} from '@cdo/apps/lib/util/urlHelpers';

const studentName = MINIMUM_TEST_PROPS.studentName;

Expand Down Expand Up @@ -58,6 +58,10 @@ describe('ConfirmRemoveStudentDialog', () => {
<strong>{i18n.removeStudentBody1()}</strong>
{' '}
{i18n.removeStudentBody2()}
{' '}
<a href={RELEASE_OR_DELETE_RECORDS_EXPLANATION} target="_blank">
{i18n.learnMore()}
</a>
</p>
</div>
<ConfirmCancelFooter
Expand Down Expand Up @@ -89,6 +93,10 @@ describe('ConfirmRemoveStudentDialog', () => {
<strong>{i18n.removeStudentBody1()}</strong>
{' '}
{i18n.removeStudentBody2()}
{' '}
<a href={RELEASE_OR_DELETE_RECORDS_EXPLANATION} target="_blank">
{i18n.learnMore()}
</a>
</p>
<div>
<p>
Expand Down