Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Joining Text for Email Logins #24811

Merged
merged 1 commit into from Sep 14, 2018
Merged

Update Joining Text for Email Logins #24811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/i18n/common/en_us.json
View file
Open in desktop
Expand Up @@ -692,6 +692,7 @@
"inspireStudents": "Inspire students",
"instructions": "Instructions",
"joinASection": "Join a section",
"joinInstructions": "Joining Instructions",
"joinSection": "Join section",
"joinSectionExplanation": "Ask your students to join your section by going to this link and entering the section code (above): ",
"joinSectionAsk": "Tell your students to create their own accounts and join your section at: ",
Expand Down
5 changes: 3 additions & 2 deletions apps/src/templates/teacherDashboard/SectionActionDropdown.jsx
View file
Open in desktop
Expand Up @@ -19,6 +19,7 @@ import DialogFooter from "./DialogFooter";
import QuickActionsCell from "@cdo/apps/templates/tables/QuickActionsCell";
import {getStore} from "@cdo/apps/redux";
import {setRosterProvider} from "@cdo/apps/templates/teacherDashboard/teacherSectionsRedux";
import {SectionLoginType} from '@cdo/apps/util/sharedConstants';

const styles = {
xIcon: {
Expand Down Expand Up @@ -55,7 +56,7 @@ class SectionActionDropdown extends Component {
};

componentDidMount() {
if (this.props.sectionData.loginType === "google_classroom" || this.props.sectionData.loginType === "clever") {
if (this.props.sectionData.loginType === OAuthSectionTypes.google_classroom || this.props.sectionData.loginType === OAuthSectionTypes.clever) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just cleaning up this change as I go by

getStore().dispatch(this.props.setRosterProvider(this.props.sectionData.loginType));
}
}
Expand Down Expand Up @@ -119,7 +120,7 @@ class SectionActionDropdown extends Component {
<PopUpMenu.Item
href={pegasus(`/teacher-dashboard#/sections/${sectionData.id}/print_signin_cards`)}
>
{i18n.printLoginCards()}
{sectionData.loginType === SectionLoginType.email ? i18n.joinInstructions() : i18n.printLoginCards()}
</PopUpMenu.Item>
}
<MenuBreak/>
Expand Down