Move failed account takeover logging to redshift, include error #24817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of Redshift logging in #24720.
Currently, when an account takeover fails due to an attempt to takeover an account with progress, we log the failure to Honeybadger (example). We originally thought that this wasn't ever really happening, but realized we were wrong. This meant lots of Honeybadger notifications for this use case.
Instead, we should be logging this to Redshift, leveraging the current logging in place. This adds a new event to Redshift:
Study:
user-soft-delete-audit
Events:
cancelled-silent-account-takeover
/cancelled-oauth-account-takeover
user_id
: user ID of account being taken overdata_int
: user ID of the account taking over user_id's accountdata_string
: OAuth provider involved in the account takeoverdata_json
:user_type
error
(currently always "Attempted takeover for account with progress.")