Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projects: project validators see view more links #24821

Merged
merged 2 commits into from Sep 17, 2018
Merged

Projects: project validators see view more links #24821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af5a061
use props v. hardcoded boolean to control view more links
Erin007 Sep 17, 2018
daf8ee3
ui test that project validators can see view more links
Erin007 Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/src/templates/projects/ProjectCardGrid.jsx
View file
Open in desktop
Expand Up @@ -114,7 +114,7 @@ class ProjectCardGrid extends Component {
labKey="applab"
labName={i18n.projectTypeApplab()}
labViewMoreString={i18n.projectTypeApplabViewMore()}
hideViewMoreLink={true}
hideViewMoreLink={this.props.limitedGallery}
projectList={projectLists.applab}
numProjectsToShow={numProjects}
galleryType={this.props.galleryType}
Expand All @@ -126,7 +126,7 @@ class ProjectCardGrid extends Component {
labKey="gamelab"
labName={i18n.projectTypeGamelab()}
labViewMoreString={i18n.projectTypeGamelabViewMore()}
hideViewMoreLink={true}
hideViewMoreLink={this.props.limitedGallery}
projectList={projectLists.gamelab}
numProjectsToShow={numProjects}
galleryType={this.props.galleryType}
Expand Down Expand Up @@ -203,7 +203,7 @@ class ProjectCardGrid extends Component {
labKey="applab"
labName={i18n.projectTypeAllProjectsApplab()}
labViewMoreString={i18n.projectsViewAll()}
hideViewMoreLink={true}
hideViewMoreLink={this.props.limitedGallery}
projectList={projectLists.applab}
numProjectsToShow={numProjects}
galleryType={this.props.galleryType}
Expand All @@ -216,7 +216,7 @@ class ProjectCardGrid extends Component {
labKey="gamelab"
labName={i18n.projectTypeAllProjectsGamelab()}
labViewMoreString={i18n.projectsViewAll()}
hideViewMoreLink={true}
hideViewMoreLink={this.props.limitedGallery}
projectList={projectLists.gamelab}
numProjectsToShow={numProjects}
galleryType={this.props.galleryType}
Expand Down
8 changes: 7 additions & 1 deletion dashboard/test/ui/features/projects/public_project_gallery_project_validator.feature
View file
Open in desktop
Expand Up @@ -67,4 +67,10 @@ Scenario: Can Toggle to the Personal Project Gallery
And I wait until element "#react-personal-projects" is visible
And element "#public-gallery" is not visible

# TODO (Erin B.) Add a test to ensure that project validators can always see the view more links for App Lab and Game Lab.
Scenario: Can See App Lab/Game Lab View More Links
Given I am on "http://studio.code.org/projects/public"
Then I wait until element "#public-gallery" is visible
Then I wait until element ".ui-project-app-type-area" is in the DOM
And the project gallery contains 7 project types
And element ".ui-project-app-type-area:eq(4)" contains text "View more App Lab projects"
And element ".ui-project-app-type-area:eq(5)" contains text "View more Game Lab projects"