Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AWS Firehose gem to 1.6 #24824

Merged
merged 1 commit into from Sep 17, 2018
Merged

Update AWS Firehose gem to 1.6 #24824

merged 1 commit into from Sep 17, 2018

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Sep 17, 2018

This might resolve HTTP connectivity issues we saw on Sunday 9/16.

@islemaster
Copy link
Contributor

Might be worth calling out that this also updates aws-sdk-core from 3.22.1 to 3.27.0.

Here's the relevant bits of the aws-sdk-firehose changelog, which doesn't tell us much,

1.6.0 (2018-09-06)
Feature - Adds code paths and plugins for future SDK instrumentation and telemetry.
1.5.0 (2018-09-05)
Feature - API update.

And here's the aws-sdk-core changelog.

3.27.0 (2018-09-06)
Feature - Adds code paths and plugins for future SDK instrumentation and telemetry to aws-sdk-sts.
3.26.0 (2018-09-05)
Feature - Updated Aws::STS::Client with the latest API changes.
Feature - Adds code paths and plugins for future SDK instrumentation and telemetry.
3.25.0 (2018-08-29)
Feature - Updated the list of parameters to filter when logging.
Issue - Add :exclude_presign option for #api_requests at client stubbing to allow excluding non-sent request from presigned url
3.24.1 (2018-08-13)
Issue - Update ca-bundle.crt file with newer root certificate authorities.
3.24.0 (2018-08-03)
Feature - Extensible Credential Providers, allows you to declare an executable to be run that outputs the credentials as a JSON payload allowing you to develop custom credential providers and easily add them to the credential resolution chain, Docs
3.23.0 (2018-07-31)
Feature - Add Logged API Requests interface to stubbed clients

Is the expectation that our pre-deploy test run will be sufficient to verify this change?

Copy link
Contributor

@wjordan wjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there specific changes within this update that we expect/hope will resolve this issue, or is this just a matter of updating to the latest in case it does happen to offer a fix?

Either way I don't have any problems with the version bump, just wondering what our expectations are.

@sureshc
Copy link
Contributor Author

sureshc commented Sep 17, 2018

There aren't any specific changes in the gem update that I expect to resolve this problem, but there have been several releases to the firehose gem in the last few months and AWS is likely to recommend updating when he re-opens the issue.

@sureshc sureshc merged commit f424bf9 into staging Sep 17, 2018
@sureshc sureshc deleted the upgrade-firehose-gem branch September 17, 2018 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants