Rescue Firehose errors #24854
Merged
Rescue Firehose errors #24854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Sep 18, 2018
lib/cdo/firehose.rb
Outdated
| @@ -61,6 +61,10 @@ def put_record(data) | |||
| # backing off and retrying. | |||
| # See http://docs.aws.amazon.com/sdkforruby/api/Aws/Firehose/Client.html#put_record-instance_method. | |||
| Honeybadger.notify(e) | |||
| rescue StandardError => error | |||
There was a problem hiding this comment.
Two suggestions:
- This clause is strictly a superset of, and has identical behavior to, the one above that rescues ServiceError. I think we could just replace the above clause with this one.
- You can just write
rescue => errorwhich is equivalent torescue StandardError => error. See Thoughbot.
sureshc
requested review from
wjordan,
maddiedierker and
mehalshah
and removed request for
ewjordan
maddiedierker
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent errors that occur when sending analytics data to Redshift via Firehose from causing the caller to fail.