Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style finish_sign_up form #24909

Merged
merged 3 commits into from Sep 24, 2018
Merged

Style finish_sign_up form #24909

merged 3 commits into from Sep 24, 2018

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Sep 20, 2018

Note: I'm not sure why the dropdown icons aren't showing up in the screenshots below, but I promise they're there (I used Chrome's new screen capture tool).

On page load

localhost-studio code org_3000_users_finish_sign_up

Upon choosing student user type

localhost-studio code org_3000_users_finish_sign_up 1

Upon choosing teacher user type

localhost-studio code org_3000_users_finish_sign_up 2

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@maddiedierker
Copy link
Contributor Author

@breville tagging you because poorva said you'll be making some UI changes to the email opt-in feature for teachers. let me know if you'd like me to change the dropdown to radio buttons while i'm here, or if it makes more sense to wait

@maddiedierker maddiedierker merged commit 048037d into staging Sep 24, 2018
@maddiedierker maddiedierker deleted the style-finish-signup branch September 24, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants