Cache blockly localization options #24930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
force-pushed
the
cache-blockly-locale-options
branch
from
28cd6c4
to
1318a1d
Compare
Changing the name with just assignment doesn't update the cache key, so the test is still testing against the old value
Hamms
changed the title
joshlory
approved these changes
Sep 27, 2018
|
Hmm, good question. The fact that this change should not result in any user-visible changes is definitely covered, but we actually disable caching for unit tests so I don't think the cache hits vs misses will be tested |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, move the localization-specific options work into a method on Blockly, a la the existing
blockly_level_optionsmethod. Then, cache the results of that per-level, script, and locale.