ignore optional free play levels in assessment progress and warning dialogs #24937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the base branch from
restore-submitted-progress-bubbles
to
staging
davidsbailey
force-pushed
the
optional-free-response
branch
from
78bcf08
to
c3a862f
Compare
davidsbailey
force-pushed
the
optional-free-response
branch
from
c3a862f
to
4689781
Compare
|
I may have linked to the wrong commits earlier. please see updated description. levelbuilder screenshot: |
islemaster
approved these changes
Sep 21, 2018
| @@ -11,6 +11,7 @@ Background: | |||
| And I wait to see ".nextPageButton" | |||
| And element ".nextPageButton" is visible | |||
|
|
|||
| @skip | |||
There was a problem hiding this comment.
Intentional to leave this @skip tag in?
There was a problem hiding this comment.
definitely not, thanks for catching!
| @@ -4,8 +4,9 @@ import { onAnswerChanged } from './codeStudioLevels'; | |||
| import { sourceForLevel } from '../clientState'; | |||
|
|
|||
| export default class FreeResponse { | |||
| constructor(levelId) { | |||
| constructor(levelId, optional = false) { | |||
There was a problem hiding this comment.
Nit: Default value false is sort of redundant since you coerce to boolean a couple of lines below.
There was a problem hiding this comment.
I must have forgotten what language I was writing in 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Teachers are still having difficulty viewing survey responses. In this zendesk ticket, the teacher suspects that students who skip optional free response questions are being scared out of confirming their submission after seeing this warning:
The solution proposed here is to mark some free response levels as "optional", eliminating them from the counting for whether to show this warning or a full progress bubble.
Description
the logic for progress bubbles and the dialog above are somewhat removed from each other, so it may be easier to look at individual commits to best understand the two changes.
ignore optional free play levels when computing assessment page progress bubble color (
e538012)
ignore optional free play levels when deciding whether to show incomplete survey warning (
e0ca1b8)
Follow-up tasks