Add migration to create pd_application_emails table #24949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
approved these changes
Sep 24, 2018
| # id :integer not null, primary key | ||
| # pd_application_id :integer not null | ||
| # application_status :string(255) not null | ||
| # email_type :string(255) not null |
There was a problem hiding this comment.
just curious - what is email_type for? receipt/reminder/etc?
There was a problem hiding this comment.
Right. It's the name of the email action. These sometimes correspond with status, but other times don't for instance principal_approval
I'm open to ideas for a better name
There was a problem hiding this comment.
I think that name makes sense, and it will be easy to tell once there are existing rows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.