Transform country name to country code upon submitting finish_sign_up… #24993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@islemaster my current plan is to write UI tests for this functionality once validation is in place. is this okay, or do you think there should be unit test(s) for this as well? |
islemaster
approved these changes
Sep 25, 2018
|
It feels slightly fragile to do a lookup based on the user-facing name, especially if we decide to localise this list at some point. One alternate approach is that in the |
breville
approved these changes
Sep 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… form
The value of the country set by
<CountryAutocompleteDropdown/>is the full string name of the country chosen from the dropdown, but we want the country to actually be the country's 2-letter country code upon submitting the signup form.