Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttle project saves on dance party levels #25003

Merged
merged 6 commits into from Sep 26, 2018

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 25, 2018

Background

work item: https://trello.com/c/P4Ge3bbu/28-turn-off-autosave-for-dance-lab-levels

Description

This implements both flags in the trello item. Once this change reaches levelbuilder, I'll turn the appropriate flags on for the dance levels via the levelbuilder machine to minimize merge conflicts.

This also stops calling onContinue twice when the user clicks Continue on levels without the new skip_run_save flag. I'm relying on existing test coverage to confirm that this doesn't break anything.

@davidsbailey
Copy link
Member Author

CC @sureshc

@joshlory
Copy link
Contributor

Test coverage?

@davidsbailey
Copy link
Member Author

Can you be more specific? Any other feedback?

@joshlory
Copy link
Contributor

Is there existing test coverage for this change, or should we track adding test coverage?

I haven't had a chance to review fully yet — sorry!

@davidsbailey
Copy link
Member Author

Good question! This existing test verifies that basic "continue" functionality still works via dismissing the dialog:

And block "6" is child of block "5"

I've added a new test which verifies that existing continue behavior works when clicking the continue button.

There is no test coverage for the new functionality yet. I will add something to this PR.

Copy link
Contributor

@joshlory joshlory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidsbailey
Copy link
Member Author

merging without tests for new functionality because (1) we want some bake time to see if this breaks "continue" behavior for any existing level types, (2) I need to put this down to work on other priorities, and (3) we may be going with a level_sources approach instead of skip_run_save anyway.

I'll revisit writing tests for this before enabling it for any /s/dance levels.

@davidsbailey davidsbailey merged commit 37fedc1 into staging Sep 26, 2018
@davidsbailey davidsbailey deleted the throttle-project-save branch September 26, 2018 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants