Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add audio/mp3 to media proxy content types #25043

Merged
merged 1 commit into from Sep 26, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Sep 26, 2018

In Code Studio, playSound("https://curriculum.code.org/media/uploads/touch.mp3"); fails because our media proxy won't pass through the content type audio/mp3

Fixed by adding this content type to the code and the corresponding test code.

@cpirich cpirich merged commit 8f182ef into staging Sep 26, 2018
@cpirich cpirich deleted the media_proxy_allow_audio_mp3 branch September 26, 2018 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants