Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly add provider to user account soft delete redshift logging #25048

Merged
merged 1 commit into from Sep 26, 2018

Conversation

maddiedierker
Copy link
Contributor

@maddiedierker maddiedierker commented Sep 26, 2018

The provider field was being recorded incorrectly for silent/OAuth account takeovers in our User account soft-delete logging to Redshift, so this makes the provider more explicit and updates the study to user-soft-delete-audit-v2 to avoid confusion with old/incorrect data.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good find!

@maddiedierker maddiedierker merged commit 6d2852f into staging Sep 26, 2018
@maddiedierker maddiedierker deleted the fix-soft-delete-redshift branch September 26, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants