Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL (Test > Levelbuilder): 1fa477ff #25055

Merged
merged 52 commits into from Sep 26, 2018
Merged

Conversation

deploy-code-org
Copy link
Contributor

No description provided.

Andrew Oberhardt and others added 30 commits September 20, 2018 23:29
DTT (Staging > Test) [robo-dtt]
…ip-only

PL regional partner search: search by ZIP only
Erin007 and others added 22 commits September 26, 2018 07:30
Use locale rather than request.language to set the Pegasus language selector
…down

Create Header: add display name to user account dropdown
…efinements

PL regional partner search: refinements
Projects: remove icons from the bottom of the personal projects page
Fixes https://app.honeybadger.io/projects/3240/faults/39671472

When the user attempts to sign in with a username or email longer than the column width of our username or email columns (255) we can safely fail to find the user without running a (potentially slow) database query.
DTT (Staging > Test) [robo-dtt]
…g-bug

Fix method missing bug in JotForm fill placeholders code
Before we used email+param for our partial registration cache key.  This is going to be a problem when we send Clever through the finish-sign-up flow because we don't trust/preserve emails of Clever students and we could get key collisions.

Instead, we're going to use provider+uid+param if possible - this will be unique for any OAuth user during registration.  As a fall-back we're switching to hashed_email+param, to avoid accidentally storing cleartext student emails.

I've also adjusted tests a bit, tearing out some of the cases that were too tightly bound to implementation.  We've still got 100% coverage on this module.  I've also added an assertion that token expiration is preserved.
…verride

Remove missing label warnings in the LabeledFormComponent...
…-on-non-daemon

Raise error when attempting to send email with attachments on a non-daemon server
DTS (Levelbuilder > Staging) [suresh]
Merge routing for finish_sign_up and sign_up paths
Login fails without query when username/email exceeds column width
PartialRegistration: Prefer provider+uid for cache key
DTT (Staging > Test) [robo-dtt]
@deploy-code-org deploy-code-org merged commit 6626064 into levelbuilder Sep 26, 2018
@davidsbailey davidsbailey deleted the dtl_candidate_1fa477ff branch September 6, 2019 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants