PL regional partner search: validate ZIP code before searching #25069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Invalid ZIP codes will just show the generic error message about no partner found.
aoby
reviewed
Sep 27, 2018
| @@ -18,7 +18,7 @@ def capacity | |||
|
|
|||
| # GET /api/v1/regional_partners/find | |||
| def find | |||
| zip_code = params[:zip_code] | |||
| zip_code = params[:zip_code] if RegexpUtils.us_zip_code?(params[:zip_code]) | |||
There was a problem hiding this comment.
Does this need to be initialized to nil otherwise, in order to be used on line 25?
There was a problem hiding this comment.
I wondered the same thing, and it worked okay, but I agree that it seems proper to initialise to nil, so I'll do that.
aoby
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid ZIP codes will just show the generic error message about no partner found.