PL regional partner search: improve one factory to have no workshops #25071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
reviewed
Sep 27, 2018
| contact_name nil | ||
| contact_email nil | ||
| apps_open_date_csp_teacher nil | ||
| apps_open_date_csd_teacher nil | ||
| apps_close_date_csp_teacher nil | ||
| apps_close_date_csd_teacher nil | ||
| mappings {[create(:pd_regional_partner_mapping, state: "NJ")]} | ||
| pd_workshops {[create(:pd_workshop, :local_summer_workshop_upcoming)]} | ||
| pd_workshops {[]} |
There was a problem hiding this comment.
If we're not overriding the default, this shouldn't be needed at all. Remove this line.
There was a problem hiding this comment.
Its parent actually does create workshops, as this one factory is the exception, not the norm.
aoby
approved these changes
Sep 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.