Principal app feedback #25078
Merged
Principal app feedback #25078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aoby
approved these changes
Sep 28, 2018
| A teacher at your school, {this.props.teacherApplication.name}, has applied to be a part | ||
| of <a href="https://code.org/educate/professional-learning-2019" target="_blank">Code.org’s Professional Learning Program</a> | ||
| {' '} in order to teach the <a href={`https://code.org/educate/${courseSuffix}`} target="_blank">{this.props.teacherApplication.course} curriculum</a> | ||
| {' '} during the {YEAR} school year. Your approval is required for the |
There was a problem hiding this comment.
This seems odd. Do we need the extra space? The {' '} and the space after it?
Also nit: move the of on line 242 to the previous line so the link stands on its own. Also please move the 2nd link on 243 to its own line. I find it more readable when the html tags are on their own line. It's easier to spot them.
mehalshah
reviewed
Sep 29, 2018
| @@ -87,7 +67,10 @@ class PrincipalApprovalApplicationsControllerTest < ::ActionController::TestCase | |||
| assert_response :success | |||
| end | |||
|
|
|||
| assert_equal 'Yes: CodeHS, CS50', teacher_application.reload.sanitize_form_data_hash[:wont_replace_existing_course] | |||
| assert_equal( | |||
| 'Yes, it will replace an existing computer science course.: CodeHS, CS50', | |||
There was a problem hiding this comment.
Kind of weird to have a period and then a colon here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug bash feedback on principal approval