Update craft #25089
Merged
Update craft #25089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes new player aquatic movement (rowing and swimming) and treasure chests.
|
+cc @ryansloan |
Hamms
reviewed
Sep 28, 2018
| @@ -533,6 +534,10 @@ Craft.executeUserCode = function () { | |||
| }, | |||
| }; | |||
|
|
|||
| const isWalkable = block => { | |||
| return block && block.isWalkable; | |||
| }; | |||
There was a problem hiding this comment.
should this change be replicated in the other craft.jss?
There was a problem hiding this comment.
This is the first year we've used isWalkable.
| @@ -374,7 +375,7 @@ Craft.initializeAppLevel = function (levelConfig) { | |||
| entities: levelConfig.entities, | |||
| playerStartPosition: levelConfig.playerStartPosition, | |||
| playerStartDirection: levelConfig.playerStartDirection, | |||
| playerName: Craft.getCurrentCharacter(), | |||
| playerName: Craft.getCurrentCharacter() + 'Aquatic', | |||
There was a problem hiding this comment.
is there a specific reason this is added here an not in getCurrentCharacter itself?
There was a problem hiding this comment.
I think because we still key the skin avatars off the base name:
code-dot-org/apps/src/craft/aquatic/craft.js
Lines 199 to 203 in ca82a02
This is following the pattern in the Designer & Hero levels:
code-dot-org/apps/src/craft/designer/craft.js
Line 529 in ca82a02
Hamms
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes new player aquatic movement (rowing and swimming) and treasure chests.