Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 presigned URL generator #25097

Merged
merged 2 commits into from
Oct 5, 2018
Merged

S3 presigned URL generator #25097

merged 2 commits into from
Oct 5, 2018

Conversation

ewjordan
Copy link
Contributor

@ewjordan ewjordan commented Sep 28, 2018

Adds a utility function to generate presigned S3 upload URLs. Once obtained, a PUT request to that URL with the desired file as the body will upload to S3..

This function does not do any validation of the bucket or the key; it is expected that the caller will make sure that the bucket and key should be accessible to the user that it is providing the URL to. Note that this allows overwriting of existing keys.

A similar method could be created for DELETEs, but I did not add that here.

@ewjordan
Copy link
Contributor Author

PTAL - updated with download and delete methods

@davidsbailey davidsbailey merged commit 68f4561 into staging Oct 5, 2018
@davidsbailey davidsbailey deleted the presigned-s3-upload branch October 5, 2018 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants