Add comment about user permissions in User#undestroy #25099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We didn't realize that when you call
undestroy
on a user, their permissions are not restored because they are hard-deleted when the user is deleted.This doesn't happen/matter very often, so adding a comment for clarity for now. When we need to restore a user account, we should ask the user if they previously had any permissions that need to be restored as well, and we'll add those manually.