Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable usertype dropdown for clever users #25106

Merged
merged 2 commits into from
Sep 28, 2018

Conversation

maddiedierker
Copy link
Contributor

We don't want Clever users (and probably more, in the future) to be able to change their user type after we receive it from OAuth, so this disables the dropdown for them (given that we did receive the user type via OAuth).

Example

screen shot 2018-09-28 at 11 59 50 am

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great! Eventually (maybe via UI tests) it'll be nice to have coverage that the dropdown actually gets disabled, and not just over the helper method.

@maddiedierker maddiedierker merged commit 763267b into staging Sep 28, 2018
@maddiedierker maddiedierker deleted the disable-usertype-clever branch September 28, 2018 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants