Account Purger Improvements #25120
Merged
Account Purger Improvements #25120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something about paranoia caued the user association to come back `nil` for QueuedAccountPurge when the user is soft-deleted... which is a fairly common scenario, and one we should handle.
This caused an automated account purge to fail today with the following error:
```
Mysql2::Error: Cannot delete or update a parent row: a foreign key constraint fails (`dashboard_production`.`census_submission_form_maps`, CONSTRAINT `fk_rails_...` FOREIGN KEY (`census_submission_id`) REFERENCES `census_submissions` (`id`)): DELETE FROM `census_submissions` WHERE `census_submissions`.`type` IN ('Census::CensusHoc2017v3') AND `census_submissions`.`id` = <redacted>
```
This is a simple join table and there's no reason to keep these rows around if the CensusSubmission is actually being deleted, so I'm updating the account purger to also delete these rows.
aoby
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an automated account purge fail today, so I took a look and came up with some improvements for the process.
Delete orphaned CensusSubmissionFormMap records
This caused an automated account purge to fail today with the following error:
This is a simple join table and there's no reason to keep these rows around if the CensusSubmission is actually being deleted, so I'm updating the account purger to also delete these rows.
Fix QueuedAccountPurge::resolve! for soft-deleted user
When I tried to use
QueuedAccountPurge.resolve!to re-run the purge after manually addressing the particular situation, something about paranoia caued the user association to come backnilfor QueuedAccountPurge when the user is soft-deleted... which is a fairly common scenario, and one we should handle. Fixes that code up to be resilient against this case.Delete multiple EmailPreference in a single query
This was nextdoor to a previous change, is well covered by tests, and is a small performance improvement.