Restore projects when undestroying user #25125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
commented
Sep 29, 2018
| PEGASUS_DB[:storage_apps]. | ||
| where(id: channel_ids, state: 'deleted'). | ||
| where(Sequel.lit('updated_at >= ?', deleted_at.localtime)). | ||
| update(state: 'active', updated_at: Time.now) |
There was a problem hiding this comment.
The most confusing thing here: We're getting a UTC Time when we grab the User's deleted_at (dashboard_db), but the updated_at storage_apps column (pegasus_db) contains a local (server?) time. Both times clearly reported information about their timezone offsets, but I guess comparing them in a Sequel literal isn't clever enough to take the timezone into account. Using .localtime to convert the User's delete time to server time before generating the Sequel literal seems to work.
islemaster
commented
Sep 29, 2018
| # Paranoia documentation at https://github.com/rubysherpas/paranoia#usage. | ||
| restore(recursive: true, recovery_window: 5.minutes) | ||
| result = restore(recursive: true, recovery_window: 5.minutes) | ||
| restore_channels_deleted_after(soft_delete_time - 5.minutes) |
There was a problem hiding this comment.
Projects are soft-deleted before the User is soft-deleted, so I'm restoring them after the User is restored and keeping the 5-minute window.
Erin007
approved these changes
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've soft-deleted and restored my prod account a few times while working on the new sign-up flow. This morning I made a 馃槺 terrifying discovery: All of my projects were gone!
It turns out we soft-delete (and unfeature) a user's projects when the user is soft-deleted, but we don't restore those projects when the user is restored. 馃槩 Fortunately it was pretty easy to write a test for this scenario and fix it.