Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PL regional partner search: small fixes #25143

Merged
merged 2 commits into from
Oct 1, 2018

Conversation

breville
Copy link
Member

@breville breville commented Oct 1, 2018

  • Also show "Notify me when I can apply" button when applications are closed. This button is now shown whenever applications are not actually open.
  • Show ZIP error if a % is included in the input, which is triggering a 400 error from the server. (All error codes from the server will now do this, in fact.)
  • Show ZIP error if a ? is included in the input, which was causing jQuery to do a jsonp request.

- Also show "Notify me when I can apply" button when applications are closed.  This button is now shown whenever applications are not actually open.
- Show ZIP error if a % is included in the input, which is triggering a 400 error from the server.  (All error codes from the server will now do this, in fact.)
- Show ZIP error if a ? is included in the input, which was causing jQuery to do a jsonp request.
@aoby aoby merged commit 3b3246d into staging Oct 1, 2018
@aoby aoby deleted the regional-partner-search-small-fixes branch October 1, 2018 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants