Set Default Song in Levelbuilder #25155
Conversation
| @@ -70,6 +70,11 @@ | |||
| #plusPreloadAssetList | |||
| %i.fa.fa-plus-circle | |||
|
|
|||
| .field | |||
| = f.label :default_song, 'Dance Lab Only - Default Song' | |||
| = f.select :default_song, options_for_select(@level.class.hoc_songs, @level.default_song) | |||
There was a problem hiding this comment.
better to wrap this .field with - if @level.is_a? Dancelab.
the next time we add a setting specific to Dancelab, we should really extract a new _dancelab.html.haml partial, and then refer to it like this:
dashboard/app/models/levels/level.rb
Outdated
| # Overriden by different level types. | ||
| def self.hoc_songs | ||
| end | ||
|
|
There was a problem hiding this comment.
ok to omit this method definition once you are ensuring that it is only called for Dancelab.
| @@ -79,6 +79,7 @@ class Blockly < Level | |||
| preload_asset_list | |||
| skip_autosave | |||
| skip_run_save | |||
| default_song | |||
There was a problem hiding this comment.
Will other app types use this in the future, or should this go in gamelab.rb?
| @@ -534,6 +534,10 @@ def blockly_options | |||
| level_options[:sharedFunctions] = nil # TODO: handle non-standard pools | |||
| end | |||
|
|
|||
| if @level.is_a? Dancelab | |||
| level_options[:defaultSong] = @level.default_song | |||
| end | |||
There was a problem hiding this comment.
I don't think we need this — the following ensures that all level properties are turned into options on appOptions.level:
code-dot-org/dashboard/app/helpers/levels_helper.rb
Lines 503 to 505 in cda7db3
Builds on: #25058 and #25081
*Adds dropdown in levelbuilder to set the default song
*Song Selection UI is auto-populated with this value
*Note: The dropdown is populated from a manually curated list of songs in dancelab.rb I left a todo in there for myself as a future step will be the use the song library manifest to populate these values.
Has no change on user-experience, so not behind the 'songSelector' flag.
Upcoming PRs:
Use the song chosen in the Song Selector UI when the project is played
Remove set song block