-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Level Concept Difficulties for new 2018 levels #25185
Conversation
@ryansloan can you spot-check the level changes to confirm that they match expectations? |
I checked a handful and they LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after resolving conflicts. Thank you for doing this import!
|
||
lcd = LevelConceptDifficulty.find_or_create_by(level: level) | ||
lcd.update!(concept_difficulties) | ||
level.write_custom_level_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only need to do this if we have a LCD for this level, right? Seeing a lot of edits on levels that don't actually change the LCD.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good catch. Lemme try and make this a bit smarter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably doesn't make a huge difference — the real (long-term) work item here is to not write values to the .level file unless they're different than the default value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated!
Based on the data contained in this spreadsheet