playSound() callback plus audio preload cleanup #25187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
playSound()
now has a 3rd parameter (callback
) - undocumented for student use. Thecallback
function will be called when the sound starts playing. This will be used by hoc dance party so we can synchronize with the playing audio.playSound()
unit tests to be aware of this change.register()
on all preloaded sounds. This means that they will not only be preloaded into the browser cache, but will also be brought into memory so that we increase the likelihood that the sound will play immediately when the student presses the Run button.