-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test run of CSP assessments #25198
Test run of CSP assessments #25198
Conversation
wrong '<img src="https://codehs.com/uploads/c7d593125a90ac3c790a78d5b5d098af" height="200">' | ||
wrong '<img src="https://codehs.com/uploads/f9506ef1e6ea5e845699feaac9686a5d" height="200">' | ||
wrong '<img src="https://codehs.com/uploads/2ffc72ca9ba682bcd443104de50ac8a5" height="200">' | ||
right '<img src="https://codehs.com/uploads/6b450add4f3ff7310fa1a3c2d6a1b27a" height="200">' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we re-host the images on images.code.org? Our network requirements only tell administrators to unblock *.code.org
and everything should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bakerfranke how many of these include images? Can we ask CodeHS for a dump of them, or are we going to need to pull urls from the JSON?
wrong '<img src="https://curriculum.code.org/media/uploads/csp/f9506ef1e6ea5e845699feaac9686a5d" height="200">' | ||
wrong '<img src="https://curriculum.code.org/media/uploads/csp/2ffc72ca9ba682bcd443104de50ac8a5" height="200">' | ||
right '<img src="https://curriculum.code.org/media/uploads/csp/6b450add4f3ff7310fa1a3c2d6a1b27a" height="200">' | ||
markdown <<MARKDOWN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshlory moved these to curriculum.code.org to unblock testing this process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. The entire dataset only contains 24 images. These few files have several of them. Thanks @mrjoshida for moving these images to curriculum.code.org. I'll figure out a way to do the others when we push the rest of the set. Anything blocking this now?
@joshlory any concern about merging this so we can figure out if the process is going to work for the larger batch? |
Test of a few CSP assessments @bakerfranke generated from his giant JSON dump