Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test run of CSP assessments #25198

Merged
merged 3 commits into from
Oct 5, 2018
Merged

Test run of CSP assessments #25198

merged 3 commits into from
Oct 5, 2018

Conversation

mrjoshida
Copy link
Contributor

Test of a few CSP assessments @bakerfranke generated from his giant JSON dump

wrong '<img src="https://codehs.com/uploads/c7d593125a90ac3c790a78d5b5d098af" height="200">'
wrong '<img src="https://codehs.com/uploads/f9506ef1e6ea5e845699feaac9686a5d" height="200">'
wrong '<img src="https://codehs.com/uploads/2ffc72ca9ba682bcd443104de50ac8a5" height="200">'
right '<img src="https://codehs.com/uploads/6b450add4f3ff7310fa1a3c2d6a1b27a" height="200">'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we re-host the images on images.code.org? Our network requirements only tell administrators to unblock *.code.org and everything should work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakerfranke how many of these include images? Can we ask CodeHS for a dump of them, or are we going to need to pull urls from the JSON?

wrong '<img src="https://curriculum.code.org/media/uploads/csp/f9506ef1e6ea5e845699feaac9686a5d" height="200">'
wrong '<img src="https://curriculum.code.org/media/uploads/csp/2ffc72ca9ba682bcd443104de50ac8a5" height="200">'
right '<img src="https://curriculum.code.org/media/uploads/csp/6b450add4f3ff7310fa1a3c2d6a1b27a" height="200">'
markdown <<MARKDOWN
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshlory moved these to curriculum.code.org to unblock testing this process

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. The entire dataset only contains 24 images. These few files have several of them. Thanks @mrjoshida for moving these images to curriculum.code.org. I'll figure out a way to do the others when we push the rest of the set. Anything blocking this now?

@mrjoshida
Copy link
Contributor Author

mrjoshida commented Oct 4, 2018

@joshlory any concern about merging this so we can figure out if the process is going to work for the larger batch?

@mrjoshida mrjoshida merged commit 8b46c0c into staging Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants