Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel signup link #25201

Merged
merged 13 commits into from
Oct 4, 2018
Merged

Cancel signup link #25201

merged 13 commits into from
Oct 4, 2018

Commits on Oct 2, 2018

  1. Display student fields by default

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    549e4a7 View commit details
    Browse the repository at this point in the history

  2. Remove user.valid? check in new_from_partial_registration

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    46b229a View commit details
    Browse the repository at this point in the history

  3. Add 'is required' error for user_type

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    8708fa1 View commit details
    Browse the repository at this point in the history

  4. Remove SHARED_FIELDS and ids since fields are no longer ever hidden

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    235792c View commit details
    Browse the repository at this point in the history

  5. Update NEW_SIGN_UP_GROUP to experiment-v2

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    382b9a4 View commit details
    Browse the repository at this point in the history

  6. Track select-#{user_type} event in finish sign up form

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    ecd87e9 View commit details
    Browse the repository at this point in the history

  7. Only call user.valid? for old signup flow, update unit tests

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    98cf8e1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'default-user-type' into log-select-user-type

    @maddiedierker
    maddiedierker committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    51bd3c2 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Add GET /users/cancel and unit test

    @maddiedierker
    maddiedierker committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    7f2f9ff View commit details
    Browse the repository at this point in the history

  2. Unit test GET /users/cancel

    @maddiedierker
    maddiedierker committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    1535493 View commit details
    Browse the repository at this point in the history

  3. Break apart finish signup strings for provider/no-provider for styling

    @maddiedierker
    maddiedierker committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    729d58f View commit details
    Browse the repository at this point in the history

  4. Fix test comment

    @maddiedierker
    maddiedierker committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    78ff61e View commit details
    Browse the repository at this point in the history

  5. Log firehose event when user cancels partial registration

    @maddiedierker
    maddiedierker committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    835c569 View commit details
    Browse the repository at this point in the history