Always run Puma in cluster mode, even with 1 worker #25213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with service script not detecting upgrade-action completion when Puma was running in single-server mode. [ci skip]
|
LGTM from a deployment perspective -- we got all the PLC fixes out last night and I think this would be fine to merge this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with service script not detecting upgrade-action completion when Puma was running in single-server mode.
This PR will always use cluster mode (serving the web-application from forked worker processes), even when the number of workers is
1. This makes single-worker environments more production-like with very little drawback (slightly increased memory usage, but not a big deal).