Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect changes to shared_constants along with apps directory to trigger a new apps build #25244

Merged
merged 2 commits into from
Oct 4, 2018

Conversation

aoby
Copy link
Contributor

@aoby aoby commented Oct 4, 2018

2nd attempt at #25225

This time it inspects the same paths in the staged changes and in the git folder hash. In both cases I expanded the check from just apps to a configurable list of paths including apps, lib/cdo/shared_constants.rb and the lib/cdo/shared_constants directory.

I tested this in all combinations locally, both in staged changes and in a commit on a new branch with nothing in staged changes:

  • no change: skip apps build
  • non-apps change, e.g. dashboard: skip apps build
  • apps change: build apps
  • shared_constants.rb change: build apps
  • shared_constants/ change: build apps

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 This looks correct to me.

@aoby aoby merged commit e4c8b29 into staging Oct 4, 2018
@aoby aoby deleted the apps-build-detect-shared-const-change2 branch October 4, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants