Sign in redirects follow up #25248
Merged
Sign in redirects follow up #25248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islemaster
reviewed
Oct 4, 2018
| return current_user.most_recent_progress_in_recently_assigned_script? || current_user.last_assignment_after_most_recent_progress? | ||
| else | ||
| return true | ||
| end |
There was a problem hiding this comment.
If your first if-expression is false this method returns nil instead of true or false, which doesn't break behavior but is a little messy.
This method could also be expressed as a single expression. I think this is equivalent:
def should_redirect_to_script_overview?
current_user.student? &&
!account_takeover_in_progress &&
current_user.most_recently_assigned_user_script &&
(
!current_user.user_script_with_most_recent_progress ||
current_user.most_recent_progress_in_recently_assigned_script? ||
current_user.last_assignment_after_most_recent_progress?
)
end
islemaster
approved these changes
Oct 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporating feedback from #25218.