Fix bug so workshop admins who are also facilitators can see all facilitator survey results

[aoby]

and add tests

[aoby]

I extracted the namespace as a module in the test which indented most of the file and makes for a noisy diff. View with whitespace changes hidden for easier review:

[aoby]

Workshop Admins who are also facilitators should be able to see all facilitator results

[tanyaparker]

Would this also fix it for a program manager who is also a facilitator?

[aoby]

Yes, and a workshop organizer. In fact that part was already done. Only workshop admin was missing.

Now, it works like this:

1. Is the user any of: workshop admin, organizer, program manager? Show all results
2. Is the user a facilitator? Show their results only
3. raise an error for unexpected user type (honeybadger)

[tanyaparker]

Yay! Thanks!