Project UI tests: improvements to project gallery ui tests #25254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Oct 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
public_project_gallery_project_validator.featureis flaky due to a test order dependency. A recent failure is documented here. This PR includes 3 improvements to the public project gallery tests:1.) Added a new step to scroll to the Play Lab section of the public gallery. Since the tests in
public_project_gallery_project_validator.featureare Play Lab projects, scrolling them into view will make debugging in future SauceLabs tests runs easier.2.) Specifically look for the first Play Lab project rather than the first project in general when checking featured/published recency by appending the project type to the class for the project name div. This will help ameliorate the test order dependency problem when our UI tests run in parallel.
3.) Assign
ProjectAppTypeAreaclasses based on project type so that the UI tests are more resilient to order changes in the project type sections in the public gallery.