Log provider to redshift for cancel- and load-finish-sign-up events #25401

maddiedierker · 2018-10-12T23:06:31Z

Going to get these changes merged while I'm still investigating events having empty data_string (session[:sign_up_uid]) fields. Consulted with @poorvasingal on this -- going to get these changes in, see if they give us any additional insight while we fix the data_string problem, then we'll bump the study/study_group version numbers.

What it does

log_oauth_callback for all providers
log provider in log_cancel_finish_sign_up and log_load_finish_sign_up
always log_sign_up_result, even if expiration has passed
add integration test for email signups in experiment/new signup flow
log study_group for all events

islemaster

👍

maddiedierker added 4 commits October 12, 2018 16:03

Log provider to redshift for cancel- and load-finish-sign-up events

cb94930

Add email integration test

6a81e60

Always log signup result to redshift, even if expiration has passed

b173244

Always log study_group

7a61e71

maddiedierker requested a review from islemaster October 15, 2018 20:19

islemaster approved these changes Oct 15, 2018

View reviewed changes

maddiedierker merged commit b977f69 into staging Oct 15, 2018

maddiedierker deleted the refactor-oauth-login-callbacks branch October 15, 2018 23:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log provider to redshift for cancel- and load-finish-sign-up events #25401

Log provider to redshift for cancel- and load-finish-sign-up events #25401

maddiedierker commented Oct 12, 2018 •

edited

islemaster left a comment

Log provider to redshift for cancel- and load-finish-sign-up events #25401

Log provider to redshift for cancel- and load-finish-sign-up events #25401

Conversation

maddiedierker commented Oct 12, 2018 • edited

What it does

islemaster left a comment

Choose a reason for hiding this comment

maddiedierker commented Oct 12, 2018 •

edited