Add dance party tile to HOC overview page #25536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breville
reviewed
Nov 8, 2018
|
Does it work okay responsively? |
maddiedierker
changed the title
breville
approved these changes
Nov 9, 2018
There was a problem hiding this comment.
One caution is to make sure this is well-tested without the DCDO flag set to "dance". Unlike our previous flips for hoc2018, we will be using DCDO to make this go live some number of days after these changes are live on production, so we have to be careful that the pre-"dance" UI looks good too.
Erin007
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a full-width resource tile about Dance Party to
/hourofcode/overview:GIF of responsiveness:
