Update HOC tiles on /courses and /sign_in #25570
Conversation
maddiedierker
changed the title
maddiedierker
changed the title
|
@poorvasingal can you take a look at the table i wrote out in the description of this PR to make sure it's correct? i laid out which course tiles English/non-English users should see based on which |
|
The Minecraft text is a little squished with "problem" on the right hand side. Does it need a little padding? Also intentional that the /courses boxes have the green "Try now" band on the bottom, but the sign in ones don't. Just curious about the consistency. |
| // First row, dynamically created based on hocLaunch value | ||
| const tiles = this.getFirstRowTiles(); | ||
| tiles.forEach((tile, index) => { | ||
| $(tile).appendTo(ReactDOM.findDOMNode(this.refs[index])); |
There was a problem hiding this comment.
snazzy. I like how you consolidated these!
| </div> | ||
|
|
||
| {this.props.rowCount > 1 && ( | ||
| <div> | ||
| <br/> | ||
| <br/> | ||
| <div className="row"> | ||
| {/* TODO: (madelynkasula) If Flappy is in 1st row, what should replace Flappy on line below? */} | ||
| {/* Can we remove 2nd row? It's never used... */} |
There was a problem hiding this comment.
Any resolution to this yet? I'm curious.
There was a problem hiding this comment.
no, i totally forgot--thank you for reminding me! 😂 i'll talk to poorva and address in a follow-up
|
Hey Maddie - Double checked the comments from Marina on the spec and your table looks right based on that. The main thing I'm unsure about is if the DCDO flag is going to be changed back to "nil" after HOC? B/c we'd want the tiles you have for the dance launch to continue to stay post-HOC. +1 to ErinB's comment on padding for the Minecraft tile. Seems like we need additional margin on the right in the tiles. I think this is true of each tile, just that it's only noticeable on MC in English b/c of the way the text ends up wrapping. ErinB - The "Try now" inconsistency is as expected. We only show the "Try now" band when you're signed in (even on the courses page). It's because it turns into "Continue" if you've already made progress in the tutorial, which we only know for a user if they are signed in. |
Updates the course tiles on
/coursesand/users/sign_in.Some examples of those with the new Dance Party tile:
On
/users/sign_in:On
/courses:For both of these pages, users with different languages settings should see the following course tiles when the
DCDO.hoc_launchflag is set to different values: