Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log DancePartyOnInit to measure real world load time #25655

Merged
merged 1 commit into from Oct 29, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Oct 29, 2018

We're concerned about how long it will take to initialize DanceParty will all of its sprite sheets over various network conditions and cache states (CDN, browser, etc.). Adding a logToCloud() call to NewRelic with a 5% sample rate so we can see how long it takes to receive the onInit() callback, which means it is possible to press the Run button.

Copy link
Contributor

@islemaster islemaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good!

@cpirich cpirich merged commit 985a841 into staging Oct 29, 2018
@cpirich cpirich deleted the log_DancePartyOnInit_to_NewRelic branch October 29, 2018 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants