Translate success and error messages for dance party puzzles #25697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yahoo! FYI, no need to create trello cards (unless it's easier for you) - I am tracking this via GitHub issues now. What syntax will I need to use to access these strings in validation code? |
|
@ryansloan in levelbuilder, you will pass the key to the fail/pass methods as a string. So if the error message is "You need to make a dancer" -- A message isn't required though (it looks like there are fallback messages elsewhere? i'm unfamiliar with where this happens, though) |
|
@madelynkasula Perfect, thanks! We don't pass messages for passing solutions, but we should be passing them for failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the success/error message on puzzle complete as the translation key rather than the message itself.
Tagging @ryansloan so he knows the messages currently on levelbuilder will need to updated to keys (and any additional strings needed will need to be added to i18n/dance/en_us.json)