New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dance captures thumbnails #25748
Merged
Merged
Dance captures thumbnails #25748
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
29e7d6a
Dance captures thumbnails
islemaster 117b3c9
Merge branch 'staging' into dance-thumbnails
maddiedierker d4a95e6
Track tickCount, add shouldCaptureImage
maddiedierker 78ae6c1
Add getThumbnailFromCanvas to store current thumbnail blob in memory
maddiedierker 734a57f
Cleanup and rename
maddiedierker 159c42f
Merge branch 'staging' into dance-thumbnails
maddiedierker 6f064a4
Save thumbnail png blob on project save if possible
maddiedierker 84a4106
Clean up comments and documentation
maddiedierker 8f9a049
Remove comment
maddiedierker 401777b
Clean up duplicate code
maddiedierker 533806a
Use milliseconds to track last thumbnail capture, increase interval t…
maddiedierker 0881ed2
Refactor min capture interval to 5 seconds for in-memory thumbnail ca…
maddiedierker 436fa40
Only attempt to save thumbnail in captureThumbnailFromCanvas if PNG b…
maddiedierker File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For later: If we can stop depending on the thumbnailURL being saved to the channel row, we'd be able to fire these requests simultaneously! I'm not sure why we do that, since it's always in the same place.