[Don't merge until DP Launch] Congrats: swap Dance Party for Minecraft #25754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -813,9 +815,6 @@ | |||
| "minecraftAquaticButton": "Go to Minecraft Education", | |||
| "minecraftAquaticDesc": "Continue learning with Minecraft.", | |||
| "minecraftAquaticTitle": "Minecraft Education", | |||
| "minecraftMarketingButton": "Start", | |||
| "minecraftMarketingDesc": "Minecraft is back for the Hour of Code with a brand new activity! Journey through Minecraft with code.", | |||
| "minecraftMarketingTitle": "Minecraft: Hero’s Journey", | |||
There was a problem hiding this comment.
i'm sure you checked, but just double-checking that these "minecraft_" strings aren't used elsewhere
There was a problem hiding this comment.
Yep, thanks for the reminder!
maddiedierker
approved these changes
Nov 1, 2018
breville
approved these changes
Nov 2, 2018
|
Heads up @breville and @madelynkasula I just updated this PR to include the final copy (hooray!) for the Dance Party and Dance Party follow-up cards. |
breville
approved these changes
Nov 2, 2018
…code-dot-org into u13-congrats-swap-in-dance
|
|
|
One last tweak to address issue: code-dot-org/dance-party#295 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last of this year's /congrats changes outline in the spec.
Students younger than 13 who finish tutorials other than Dance, one of the Minecrafts or AppLab, will see a card promoting Dance Party rather than Minecraft Hero.
BEFORE:
AFTER:
