Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dance Landing: student projects animation proof of concept #25772

Merged
merged 1 commit into from Nov 2, 2018
Merged

Dance Landing: student projects animation proof of concept #25772

merged 1 commit into from Nov 2, 2018

Conversation

Erin007
Copy link
Contributor

@Erin007 Erin007 commented Nov 2, 2018

animation-projects

@Erin007 Erin007 requested review from islemaster, nkiruka and Hamms and removed request for islemaster November 2, 2018 03:55
@Erin007
Copy link
Contributor Author

Erin007 commented Nov 2, 2018

@Hamms I think you're slated to work on gifs of dance party project thumbnails? This little bunny gif seems to work well size-wise etc so if you follow that example, and put in the same file when they're ready that would be great. Let me know how I can help. Thanks!

@Hamms
Copy link
Contributor

Hamms commented Nov 2, 2018

Oh, I actually wasn't aware we were planning on doing gifs for the thumbnails, and I had thought @islemaster was going to be doing thumbnails

@Erin007
Copy link
Contributor Author

Erin007 commented Nov 2, 2018

@Hamms, sorry I was confused/misinformed. Just checked with Ryan and we're all sorted. Brad is working on the non-animated Dance Party thumbnails for the project gallery; the gifs used here will be different. No work needed from you!

@Erin007 Erin007 requested review from islemaster and removed request for Hamms November 2, 2018 04:47
nkiruka
nkiruka approved these changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@nkiruka nkiruka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erin007 Erin007 merged commit 5ade624 into staging Nov 2, 2018
@Erin007 Erin007 deleted the animated-dance-projects branch November 2, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkiruka nkiruka nkiruka approved these changes

@islemaster islemaster Awaiting requested review from islemaster

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Erin007 @Hamms @nkiruka