update pegasus & dashboard 404 to new sad bee layout #25913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanyaparker
changed the title
|
The dashboard page still doesn't have the navbar, doesn't have the footer, and isn't localized... but it has the friendlier look. Considering this v1 and we can do the other stuff later. |
breville
reviewed
Nov 8, 2018
| <div class="error-child"> | ||
| <img class="error-image" src="/shared/images/sad-bee-avatar.png" alt="Page not found"/> | ||
| <h1>404: Page Not Found</h1> | ||
| <div class="error-message">The page you are looking for doesn't exist at this address. Check the web address and resubmit. Or, go back to our homepage.</div> |
There was a problem hiding this comment.
Oh, we don't loc the 404 on dashboard?
There was a problem hiding this comment.
Correct. This page wasn't loc'ed before, but at least now the text is pulled out of the image. And we're one step closer to loc'ing later.
breville
reviewed
Nov 8, 2018
| border: 1px solid #CCC; | ||
| border-right-color: #999; | ||
| border-bottom-color: #999; | ||
| button { |
There was a problem hiding this comment.
It would be great to load this from existing CSS instead of duplicating.
There was a problem hiding this comment.
I will look into this for v2.
breville
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec
Pegasus 404
Dashboard 404