Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dance page - amazon future engineer section #25915

Merged
merged 4 commits into from Nov 8, 2018
Merged

Conversation

nkiruka
Copy link
Contributor

@nkiruka nkiruka commented Nov 8, 2018

This PR is to display the amazon future engineer section.

Implementation

  • Add view partial for the generating the tiles
  • Bold tile title and button text (style added to css)
  • Made section responsive

Screen shots

screen shot 2018-11-07 at 2 59 07 pm

@nkiruka nkiruka requested a review from Erin007 November 8, 2018 02:36
@Erin007
Copy link
Contributor

Erin007 commented Nov 8, 2018

In the screenshot, the top two cards have bold titles and buttons, but that's not the case for the bottom two cards. Just a screenshot issue or are the styles not being applied broadly?

@nkiruka
Copy link
Contributor Author

nkiruka commented Nov 8, 2018

@Erin007 It's a screen shot issue, I will update with a better image.


.resources
- resources.each do |resource|
.tile-container-responsive{style: "padding: 5px;"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can pull out the in-line styles in this file since there's a css file for it.

@nkiruka nkiruka merged commit ad541d6 into staging Nov 8, 2018
@nkiruka nkiruka deleted the amazon-section-dance-page branch November 8, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants