Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dance page - Hide amazon section based on locale #25916

Merged
merged 4 commits into from Nov 8, 2018
Merged

Conversation

nkiruka
Copy link
Contributor

@nkiruka nkiruka commented Nov 8, 2018

This PR is to hide or show the Amazon future engineer section based on locale. The amazon future engineer program is only offered in the U.S.

Implementation

A conditional was set to check locale setting. The Amazon section is visible when the locale is set to English. If the locale is not English, the section title and the four tiles are not visible.

gif

locale_setting

@nkiruka nkiruka requested a review from Erin007 November 8, 2018 03:43
@nkiruka nkiruka changed the title Hide amazon section Dance page - Hide amazon section based on locale Nov 8, 2018
@Erin007
Copy link
Contributor

Erin007 commented Nov 8, 2018

Latest staging to reduce the diff?

@nkiruka nkiruka merged commit 99f309b into staging Nov 8, 2018
@nkiruka nkiruka deleted the hide-amazon-section branch December 20, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants