Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dance page - Update assets in teacher resources section #25940

Merged
merged 4 commits into from Nov 9, 2018
Merged

Dance page - Update assets in teacher resources section #25940

merged 4 commits into from Nov 9, 2018

Conversation

nkiruka
Copy link
Contributor

@nkiruka nkiruka commented Nov 9, 2018

This PR is to update the image and gif for the teacher resources cards.

Before Implementation - screen shot

screen shot 2018-11-08 at 2 52 19 pm

Screen shot (After Implementation)

screen shot 2018-11-08 at 2 41 16 pm

@breville
Copy link
Member

breville commented Nov 9, 2018

I think best to use all lowercase for image filenames.

@nkiruka
Copy link
Contributor Author

nkiruka commented Nov 9, 2018

@breville All done! please review.

maddiedierker
maddiedierker approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great!

@nkiruka nkiruka merged commit d027574 into staging Nov 9, 2018
@nkiruka nkiruka deleted the dance-update-teacher-resources-assets branch December 20, 2018 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddiedierker maddiedierker maddiedierker approved these changes

@breville breville Awaiting requested review from breville

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nkiruka @breville @maddiedierker